[129459] trunk/dports/multimedia/mpv

[Ryan Schmidt]

On Dec 13, 2014, at 9:25 PM, Mihai Moldovan wrote:

> On 14.12.2014 04:11 AM, Ryan Schmidt wrote:
>> On Dec 13, 2014, at 8:26 PM, Mihai Moldovan wrote:
>>> 
>>> So, as soon as I use master_sites-append
>>> http://ftp.waf.io/pub/release:waf, this stuff breaks. How is this even
>>> possible?
>>> 
>> 
>> Not base; the github portgroup. These special features you reference only 
>> take effect when master_sites is at its default value. I didn't consider the 
>> case of appending another URL to master_sites when designing the github 
>> portgroup... This could probably be fixed in the portgroup, if we decide
>> what the criteria should be. For example, we might decide that if any 
>> space-separated value in master_sites is the default URL, or perhaps if just 
>> the first one is, then those special features should take effect.
> 
> THANK YOU! I've just spent an hour looking through base and couldn't for the
> love of deity find out where this move is taking place.
> 
> I guess we could just lose the master_sites == github.master_sites check. What
> is it good for, if the PortGroup checks for the directory name format being
> ${project}-${name}-* already?

Those checks went through many revisions, not all by me, to ensure that we only rename the directory when it is correct to do so. I agree the complete set of checks seems overly cautious right now, I was just glad when the bug reports stopped and the portgroup seemed to be working in all cases, and I didn't look to optimize it further at that point.

Also, whatever change we make to this part of the github portgroup should be repeated in the bitbucket portgroup which was based on it.