[115574] trunk/dports/graphics/makeicns/Portfile

[Jeremy Huddleston Sequoia]

On Jan 5, 2014, at 13:14, Ryan Schmidt <ryandesign at macports.org> wrote:

> 
> On Jan 5, 2014, at 13:58, jeremyhu at macports.org wrote:
> 
>> Revision
>> 115574
>> Author
>> jeremyhu at macports.org
>> Date
>> 2014-01-05 11:58:38 -0800 (Sun, 05 Jan 2014)
>> Log Message
>> 
>> makeicns: Link against correct C++ runtime
> 
>> Modified: trunk/dports/graphics/makeicns/Portfile (115573 => 115574)
> 
>> +# TODO: Check ${configure.cxx_stdlib} directly once MacPorts 2.3 is released
>> +platform darwin {
>> +    set cxxstdlib {}
>> +
>> +    if {[info exists configure.cxx_stdlib] &&
>> +        ${configure.cxx_stdlib} ne {} &&
>> +        [string match *clang* ${configure.cxx}]} {
>> +        set cxxstdlib ${configure.cxx_stdlib}
>> +    } elseif {[string match *clang* ${configure.cxx}] &&
>> +              ${os.major} >= 13} {
>> +        set cxxstdlib libc++
>> +    } else {
>> +        set cxxstdlib libstdc++
>> +    }
>> +
>> +    if {[string match *clang* ${configure.cxx}]} {
>> +        configure.cxxflags-append -stdlib=${cxxstdlib}
>> +        configure.ldflags-append -stdlib=${cxxstdlib}
>> +    }
>> +}
> 
> It sucks having to add this boilerplate to each port. How do we fix base to make this unnecessary? Or does trunk already take care of it?

Once 2.3 is released, that entire hunk will become:

if {[string match *clang* ${configure.cxx}]} {
    configure.cxxflags-append -stdlib=${configure.cxx_stdlib}
    configure.ldflags-append -stdlib=${configure.cxx_stdlib}
}

Hence my "TODO.*2.3" comment.  I'll be going through and simplifying all that cruft once we release the next version of base.

--Jeremy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4145 bytes
Desc: not available
URL: <https://lists.macosforge.org/pipermail/macports-dev/attachments/20140105/01554099/attachment.p7s>