[121692] trunk/dports/sysutils

[Aljaž Srebrnič]

On 07/lug/2014, at 21:51, Ryan Schmidt <ryandesign at macports.org> wrote:

> 
> On Jul 4, 2014, at 9:14 AM, kimuraw at macports.org wrote:
> 
>> Revision
>> 121692
>> Author
>> kimuraw at macports.org
>> Date
>> 2014-07-04 07:14:30 -0700 (Fri, 04 Jul 2014)
>> Log Message
>> 
>> sysutils/peco: new port "peco" - http://peco.github.io
>> 
>> 
>> peco can be a great tool to filter stuff like logs, process stats,
>> find files, because unlike grep, you can type as you think and look
>> through the current results.
>> 
>> Added Paths
>> 
>> 	• trunk/dports/sysutils/peco/
>> 	• trunk/dports/sysutils/peco/Portfile
>> Diff
>> 
>> Added: trunk/dports/sysutils/peco/Portfile (0 => 121692)
>> 
>> --- trunk/dports/sysutils/peco/Portfile	                        (rev 0)
>> +++ trunk/dports/sysutils/peco/Portfile	2014-07-04 14:14:30 UTC (rev 121692)
>> 
>> @@ -0,0 +1,82 @@
>> 
>> +# $Id$
> 
> The modeline is missing, and there should be a blank line after the $Id$ line.
> 
> 
>> +master_sites    https://github.com/peco/peco/tarball/v${version}:peco
> 
> Since this project is hosted at github, consider using the github 1.0 portgroup. The multiple distfiles might however be a complication.
> 
> 
>> +destroot {
>> +    xinstall "${worksrcpath}/peco" "${destroot}/${prefix}/bin"
>> +}
> 
> There's no need for quotes around those variables; this isn't a shell script.
> 
> There should be no "/" before "${prefix}" because ${prefix} already begins with a slash.

Also, it looks like the port install multiple programs/libraries. Perhaps it would be easier to separate them in multiple ports.

Should we start thinking about a golang PortGroup?

--
Aljaž Srebrnič a.k.a g5pw
My public key:  http://bit.ly/g5pw_pubkey