[121692] trunk/dports/sysutils
kimura wataru
kimuraw at macports.org
Tue Jul 8 05:43:48 PDT 2014
Thanks Ryan,
I fixed issues you suggested at r121804.
On Mon, 07 Jul 2014 14:51:49 -0500, Ryan Schmidt wrote:
>
> On Jul 4, 2014, at 9:14 AM, kimuraw at macports.org wrote:
>
>> Added: trunk/dports/sysutils/peco/Portfile (0 => 121692)
>>
>> --- trunk/dports/sysutils/peco/Portfile (rev 0)
>> +++ trunk/dports/sysutils/peco/Portfile 2014-07-04 14:14:30 UTC (rev
>> 121692)
>>
>> @@ -0,0 +1,82 @@
>>
>> +# $Id$
>
> The modeline is missing, and there should be a blank line after the
> $Id$ line.
>
>
>> +master_sites https://github.com/peco/peco/tarball/v${version}:peco
>
> Since this project is hosted at github, consider using the github 1.0
> portgroup. The multiple distfiles might however be a complication.
>
>
>> +destroot {
>> + xinstall "${worksrcpath}/peco" "${destroot}/${prefix}/bin"
>> +}
>
> There's no need for quotes around those variables; this isn't a shell
> script.
>
> There should be no "/" before "${prefix}" because ${prefix} already
> begins with a slash.
>
>
--
kimura wataru
More information about the macports-dev
mailing list