[122233] trunk/dports/games/gnubg

[Ryan Schmidt]

On Jul 18, 2014, at 12:21 AM, dtakahashi at macports.org wrote:

> Revision
> 122233
> Author
> dtakahashi at macports.org
> Date
> 2014-07-17 22:21:52 -0700 (Thu, 17 Jul 2014)
> Log Message
> 
> gnubg: update to the current version
> Modified Paths
> 
> 	• trunk/dports/games/gnubg/Portfile

Thanks! So this addresses #39867? What about #42590?


> +                        --with-python=${prefix}/bin/python \

Use a specific python; do not assume ${prefix}/bin/python exists or points to any usable version of python. ${prefix}/bin/python is for the user's convenience and should not be relied on by ports. Since your notes later mention py27 ports, and since you've already declared a dependency on port:python27, use ${prefix}/bin/python2.7 here.

> +notes \
> +"Recommended ports:
> +  py27-mysql    provides the MySQL backend of a game database
> +  py27-pygersql provides the PostgreSQL backend of a game database"

Did you mean py27-pygresql?


> +variant board3d description enable OpenGL board {
> +  depends_lib-append      port:gtkglext
> +  ## disable 3D board on the quartz variants
> +  ## because of the display issue
> +  ## see also https://mail.gnome.org/archives/gtkglext-list/2009-December/msg00023.html

Indentations should be at multiples of 4 spaces to match our style guidelines.


> +  configure.args-delete   --without-board3d
> +  configure.args-append   --with-board3d

When replacing one value with another, instead of invoking both -delete and -append, consider using -replace; that's what it's for.