[121213] trunk/dports/gis/gdal/Portfile

Ryan Schmidt ryandesign at macports.org
Sat Jun 21 03:20:06 PDT 2014


On Jun 20, 2014, at 7:40 AM, vince at macports.org wrote:

> Revision
> 121213
> Author
> vince at macports.org
> Date
> 2014-06-20 05:40:25 -0700 (Fri, 20 Jun 2014)
> Log Message
> 
> Use libjson-c if available, otherwise the internal code. 
> Should fix #44098

Also, you changed the compiler used by the +perf variant and removed the +python24 and +python25 variants.

> Modified: trunk/dports/gis/gdal/Portfile (121212 => 121213)

> +# Choose external libjson if available (#44098)
> +if {[file exists ${prefix}/lib/libjson-c.dylib]} {
> +    configure.args-append   --with-libjson-c=${prefix}/lib
> +} else {
> +    configure.args-append   --with-libjson-c=internal
> +}

I realize you already changed this in a subsequent commit to never use the json-c port and to always use the internal version. But I wanted to point out that the above code makes the port build differently depending on which other ports the user already has installed, which is something we don't want ports to do. Builds should be repeatable, and should do the same thing each time.



More information about the macports-dev mailing list