[121135] trunk/dports/net/tcpreplay

[Joshua Root]

On 2014-6-22 09:35 , Ryan Schmidt wrote:
> 
> On Jun 18, 2014, at 10:56 AM, snc at macports.org wrote:
> 
>> Revision
>> 121135
>> Author
>> snc at macports.org
>> Date
>> 2014-06-18 08:56:55 -0700 (Wed, 18 Jun 2014)
>> Log Message
>>
>> tcpreplay: update to 3.4.4, #41101
> 
> This does not update the port to 3.4.4; the port was already at 3.4.4.
> 
>> Modified Paths
>>
>> 	• trunk/dports/net/tcpreplay/Portfile
>> Added Paths
>>
>> 	• trunk/dports/net/tcpreplay/files/
>> 	• trunk/dports/net/tcpreplay/files/tcpreplay_maverick.patch
>> Diff
>>
>> Modified: trunk/dports/net/tcpreplay/Portfile (121134 => 121135)
>>
>> --- trunk/dports/net/tcpreplay/Portfile	2014-06-18 15:48:22 UTC (rev 121134)
>> +++ trunk/dports/net/tcpreplay/Portfile	2014-06-18 15:56:55 UTC (rev 121135)
>>
>> @@ -7,7 +7,7 @@
>>
>>  license             BSD ISC
>>
>>  version             3.4.4
>>
>>  platforms           darwin
>>
>> -maintainers         wohner.eu:normen
>>
>> +maintainers         pmq openmaintainer
>>
>>  
>>
>>  description         Replay pcap files at arbitrary speeds onto the network
>>
>>  long_description    \
>>
>> @@ -32,3 +32,6 @@
>>
>>  
>>
>>  configure.args      --with-libpcap=${prefix} \
>>
>>                      --with-tcpdump=${prefix}/sbin/tcpdump
>>
>> +
>> +configure.cflags-append	-D_FORTIFY_SOURCE=0
>> +
>>
>> Added: trunk/dports/net/tcpreplay/files/tcpreplay_maverick.patch (0 => 121135)
>>
>> --- trunk/dports/net/tcpreplay/files/tcpreplay_maverick.patch	                        (rev 0)
>> +++ trunk/dports/net/tcpreplay/files/tcpreplay_maverick.patch	2014-06-18 15:56:55 UTC (rev 121135)
>>
>> @@ -0,0 +1,11 @@
>>
>> +--- /opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/net/tcpreplay/Portfile
>> 	2013-07-15 18:03:08.000000000 +0200
>> ++++ Portfile	2013-11-01 11:56:37.000000000 +0100
>> +@@ -32,3 +32,8 @@
>> + 
>> + configure.args      --with-libpcap=${prefix} \
>> +                     --with-tcpdump=${prefix}/sbin/tcpdump
>> ++
>> ++if {${os.platform} == "darwin" && ${os.major} == 13} {
>> ++	configure.cflags-append	-D_FORTIFY_SOURCE=0
>> ++}
> 
> This patch seems to be a patch meant to be applied to the portfile, not added to the files directory.

Besides which, turning off _FORTIFY_SOURCE is a bad idea. The correct
fix is for the source file to include the right header rather than
declaring its own prototype, or to do something along the lines of
<https://trac.macports.org/attachment/ticket/40763/patch-gethostname.c.diff>

- Josh