[117622] trunk/base/src/macports1.0

[Clemens Lang]

Hi,

> The commit message did not mention the change to macports.tcl that you also
> made:
> 
> > Modified: trunk/base/src/macports1.0/macports.tcl (117621 => 117622)
> > 
> > --- trunk/base/src/macports1.0/macports.tcl	2014-03-05 22:19:14 UTC (rev
> > 117621)
> > +++ trunk/base/src/macports1.0/macports.tcl	2014-03-05 22:21:12 UTC (rev
> > 117622)
> > 
> > @@ -4508,15 +4508,6 @@
> > 
> >                          continue;
> > 
> >                      }
> > 
> >  
> > 
> > -                    if {(${filepath} == "/usr/lib/libstdc++.6.dylib" &&
> > ${macports::cxx_stdlib} == "libc++") ||
> > -                        (${filepath} == "/usr/lib/libc++.1.dylib" &&
> > ${macports::cxx_stdlib} == "libstdc++")} {
> > -
> > -                        if {$fancy_output} {
> > -                            $revupgrade_progress intermission
> > -                        }
> > -                        ui_warn "${bpath} uses ${filepath} as C++ standard
> > library although macports::cxx_stdlib is set to ${macports::cxx_stdlib}."
> > -                    }
> > -
> > 
> >                      set libresultlist [machista::parse_file $handle
> >                      $filepath]
> > 
> >                      set libreturncode [lindex $libresultlist 0]
> > 
> >                      set libresult     [lindex $libresultlist 1]
> 
> Is this change intentional or at least ok, or should it be reverted?

Thanks for catching that. I thought I had paid enough attention to avoid committing this (because I really wanted to discuss it on the list first), but it seems it still slipped in. I'm much more used to my git workflow where I can do partial adds and staging to avoid this.

-- 
Clemens Lang