[119913] trunk/dports/aqua

[Ryan Schmidt]

On May 9, 2014, at 17:12, sean at macports.org wrote:

> Revision
> 119913
> Author
> sean at macports.org
> Date
> 2014-05-09 15:12:43 -0700 (Fri, 09 May 2014)
> Log Message
> 
> inkscape-app: add new port to create an .app for inkscape
> Added Paths
> 
> 	• trunk/dports/aqua/inkscape-app/
> 	• trunk/dports/aqua/inkscape-app/Portfile
> 	• trunk/dports/aqua/inkscape-app/files/
> 	• trunk/dports/aqua/inkscape-app/files/Info.plist
> Diff
> 
> Added: trunk/dports/aqua/inkscape-app/Portfile (0 => 119913)
> 
> --- trunk/dports/aqua/inkscape-app/Portfile	                        (rev 0)
> +++ trunk/dports/aqua/inkscape-app/Portfile	2014-05-09 22:12:43 UTC (rev 119913)
> 
> @@ -0,0 +1,45 @@
> 
> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
> +# $Id$
> +
> +PortSystem          1.0
> +
> +name                inkscape-app
> +version             0.48
> +license             GPL-2+
> +maintainers         nomaintainer

"platforms darwin" is needed somewhere.


> +description         Inkscape.app application bundle
> +long_description    ${description}
> +
> +categories          aqua graphics
> +homepage            http://gimp-app.sourceforge.net

Is this homepage correct, or was this a copy/paste from another port?


> +depends_run         bin:inkscape:inkscape
> +
> +# we only need to download the icns file
> +master_sites        https://github.com/piksels-and-lines-orchestra/inkscape/raw/master/packaging/macosx/Resources
> +
> +distfiles           Inkscape.icns

Unversioned distfile. If it ever changes you'll need to use this recipe:

https://trac.macports.org/wiki/PortfileRecipes#unversioned-distfiles


> +destroot {
> +    set inkapp ${destroot}${applications_dir}/Inkscape.app
> +    xinstall -d ${inkapp}/Contents/MacOS
> +    xinstall -d ${inkapp}/Contents/Resources
> +
> +    xinstall ${filespath}/Info.plist ${inkapp}/Contents/
> +    xinstall ${worksrcpath}/Inkscape.icns ${inkapp}/Contents/Resources/

"-m 644" should be used on these xinstalls to avoid the execute bit being set.

> +    ln -s ${prefix}/bin/inkscape ${inkapp}/Contents/MacOS/Inkscape
> +}

Looks like this port probably wants "supported_archs noarch" since none of the above are architecture-specific.


> --- trunk/dports/aqua/inkscape-app/files/Info.plist	                        (rev 0)
> +++ trunk/dports/aqua/inkscape-app/files/Info.plist	2014-05-09 22:12:43 UTC (rev 119913)
> @@ -0,0 +1,54 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">

It's a nitpick, but these days it's:

<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">


> +	<key>CFBundleVersion</key>
> +	<string>389</string>

Is this version number correct?