[128555] trunk/dports/gis/saga

[Mojca Miklavec]

On Sun, Nov 23, 2014 at 12:34 PM, Vincent Habchi wrote:
> Hi Ryan,
>
>> /opt/local/Library/Frameworks should not be hardcoded here. Are you sure commenting out the reinplace is correct?
>
> Will change the hardcoded path. Thanks for pointing that out.
>
> Yes, surprisingly it seems something has changed in the configure script between 2.1.3 and 2.1.4. With the new release, the configure script seems alright as to WxWidget configuration detection, yet somehow patching the other files is still necessary.

The "configure script seems alright as to wxWidget configuration"
might be a consequence of your machine having a working wx-config in
path, so you need to double-check that this isn't the case.


The following patch is certainly wrong:

-# the test could be extended to check for wx-config --version too
-if test "`wx-config --list | grep unicode`" != "" ; then
+# the test could be extended to check for
/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/bin/wx-config
--version too
+if test "`/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/bin/wx-config
--list | grep unicode`" != "" ; then

You should not hardcode the path. Keep using reinplace with
${wxWidgets.wxconfig}.


I din't try to understand the details of the configure/build scripts, but
    grep -r wx-config .
returns *many* results with things like
    ./configure.ac:if test "`wx-config --list | grep unicode`" != "" ; then
    ./src/modules/garden/garden_3d_viewer/Makefile.am:DEP_LFLG = -fPIC
-shared `wx-config --unicode=no --static=no --libs`

All that is certainly wrong. They should be using wxwin.m4 and then
use a variable WXCONFIG rather than hardcoded values. One should
submit a bug report upstream.

My post is not about whether or not old patches are still needed, or
maybe if new ones are needed now, but just to point out that in the
current situation it seems most likely that you need reinplace and
that all the places where `wx-config ...` is called seem somewhat
suspicious.

Mojca