[127265] trunk/dports/cad

[Mark Brethen]

On Oct 25, 2014, at 7:12 AM, Kurt Hindenburg <kurt.hindenburg at gmail.com> wrote:

> 
> On Oct 24, 2014, at 5:32 PM, Ryan Schmidt <ryandesign at macports.org> wrote:
> 
>> 
>>> On Oct 24, 2014, at 9:15 AM, khindenburg at macports.org wrote:
>>> 
>>> Revision
>>> 127265
>>> Author
>>> khindenburg at macports.org
>>> Date
>>> 2014-10-24 07:15:50 -0700 (Fri, 24 Oct 2014)
>>> Log Message
>>> 
>>> freecad: new port - maintainer - #44097
>> 
>>> Added: trunk/dports/cad/freecad/Portfile (0 => 127265)
>> 
>>> +post-patch {
>>> +    reinplace "s|QLibraryInfo::location.*|QLatin1String\(\"${applications_dir}/Qt4/\"\);|" \
>>> +        ${worksrcpath}/src/Gui/Assistant.cpp
>> 
>> Here you've correctly used ${applications_dir}...
>> 
>>> +    reinplace "s|/Applications|/Applications/MacPorts|" \
>>> +        ${worksrcpath}/src/Mod/OpenSCAD/OpenSCADUtils.py
>> 
>> ...but here you've hardcoded its value /Applications/MacPorts, which should be changed to ${applications_dir}.
>> 
> Thanks r127325 - I’m thinking I should alter ‘port lint’ to display some common issues like this.
>   Kurt
> 
> 

Sorry, my bad. Do I need to submit a ticket?

Mark