[134840] trunk/dports/multimedia/x264/Portfile

[David Evans]

On 4/8/15 9:12 AM, Joshua Root wrote:
> On 2015-4-9 02:08 , "David Evans" wrote:
>> On 4/8/15 9:03 AM, David Evans wrote:
>>> On 4/8/15 8:58 AM, Joshua Root wrote:
>>>>> Revision: 134840
>>>>>             https://trac.macports.org/changeset/134840
>>>>> Author:   devans at macports.org
>>>>> Date:     2015-04-08 08:48:12 -0700 (Wed, 08 Apr 2015)
>>>>> Log Message:
>>>>> -----------
>>>>> x264: remove unnecessary use of eval.
>>>>>
>>>>> Modified Paths:
>>>>> --------------
>>>>>       trunk/dports/multimedia/x264/Portfile
>>>>>
>>>>> Modified: trunk/dports/multimedia/x264/Portfile
>>>>> ===================================================================
>>>>> --- trunk/dports/multimedia/x264/Portfile    2015-04-08 15:45:13 UTC
>>>>> (rev 134839)
>>>>> +++ trunk/dports/multimedia/x264/Portfile    2015-04-08 15:48:12 UTC
>>>>> (rev 134840)
>>>>> @@ -61,7 +61,7 @@
>>>>>        } else {
>>>>>            configure.args-append
>>>>> --host=${build_arch}-apple-darwin${os.major}
>>>>>        }
>>>>> -    eval configure.ldflags-append ${configure.cc_archflags}
>>>>> +    configure.ldflags-append ${configure.cc_archflags}
>>>> You probably need a {*} there.
>>>>
>>>> - Josh
>>>>
>>> I assumed that configure.ldflags was a list, itself.
>> And that appending a list to it would just extend the list.  Wrong?
> Yep. Appending a list to a list is different to concatenating two lists.
>
> - Josh
>
Another lesson learned.  Fixed in r134841.  Thanks.

Dave