ansible r139409

[Blair Zajac]

+macports-dev at lists.macosforge.org

BTW, I hopefully finally fixed the versioning in r139413 so it looks like

name            ansible
epoch           1
categories      sysutils

github.setup    ${name} ${name} 1.9.2-1 v
version         [string map {- .} ${version}]
fetch.type      git

> On Aug 16, 2015, at 9:46 AM, Andrew Fernandes <adfernandes at macports.org> wrote:
> 
> Ah, didn't realize that the epoch wasn't reset by the version... but in retrospect, that's obvious because that's what the revision tag is for.

I’m not sure what you mean here. The version string doesn’t contain the epoch in it.

MacPorts versioning uses semantic versioning (http://semver.org/) with the value ${epoch}.${version}.${revision} to compare if an installed port is out of date. ${epoch} defaults to 0.

> As for the wonky "v" in the version tag, github requires the "v" doesn't it?

Yes, that’s what the last ‘v’ is for in

github.setup    ${name} ${name} 1.9.2-1 v

BTW, I used ccm’s Port as a model for this github, where the tags are called ‘ccm-2.0.3’.

https://svn.macports.org/repository/macports/trunk/dports/databases/ccm/Portfile

github.setup    pcmanus ccm 2.0.3 ccm-

> You know, the MacPorts guide needs some TLC... I google most things that think of... but many parts of ports "requirements" vs "best practices" are not really well documented. (And yes, I've read the wiki, and yes I go over the guide, and yes, I google the wiki.) There's a LOT of wisdom that is really difficult for a casual maintainer to get right!

Yes, I end up copy/pasting code from one port to another. Just trying to remember a good port to use as a model is the hard part now ;)

> Even using sub-ports and the github port group... yes, there is documentation in the dports source...
> 
> Sigh. But anyway - thank you for fixing. But... and I may be wrong here, but the version is incorrect. The version tagged by the ansible team is "1.9.2-1". Yes, they use that last digit. No, I don't know why. And that's what they discuss on their issues list. https://github.com/ansible/ansible/releases

Yes, I was trying to separate the -1. Unfortunately, I wish they used a . instead of a -. This should be fixed in r139413.

The odd thing is that the tarballs listed at http://releases.ansible.com/ansible do not contain the last -1.

> I'm not going to touch this port in the future, I think. The issue is not macports, it's the wonky versioning, tagging, and releasing of the ansible team. It's making me really leery of using it in production, to be honest.

Don’t let this experience of MacPorts stop you from maintaining this port. At this point, it’s in good shape. Feel free to tweak it and ask me for a review if you’re unsure of anything.

In my case, I would edit the Port and do a

port -v info ansible
port -v lint ansible

to make sure they work fine.

Blair

> 
> Especially their "the submodules are optional, except they're not" attitude.
> 
> -A.
> 
> 
> On Sun, Aug 16, 2015 at 12:33 PM, Blair Zajac <blair at orcaware.com> wrote:
> 
> > On Aug 16, 2015, at 9:14 AM, Brandon Allbery <allbery.b at gmail.com> wrote:
> >
> > Just saw this go by in the update tracker:
> >
> > Index: /trunk/dports/sysutils/ansible/Portfile
> > ===================================================================
> > --- /trunk/dports/sysutils/ansible/Portfile   (revision 139408)
> > +++ /trunk/dports/sysutils/ansible/Portfile   (revision 139409)
> > @@ -7,9 +7,8 @@
> >
> >  name            ansible
> > -version         1.9.2
> > -epoch           1
> > +version         1.9.2-1
> >  categories      sysutils
> >
> > -github.setup    ${name} ${name} v${version}-${epoch}
> > +github.setup    ${name} ${name} v${version}
> >  fetch.type      git
> >
> > Removing the epoch sets it to 0; since it looks like the epoch was already 1 before r139408 and there may be existing installations with that epoch, those installations will never update in the future.
> >
> > The epoch must *never* go backwards.
> >
> > I would suggest restoring the epoch to 1 and leaving it alone from now on unless there is some specific need to force installation of an older version.
> >
> > https://guide.macports.org/#reference.keywords see under "epoch”.
> 
> Fixed in r139410 along with the odd version number starting with a ‘v’.
> 
> Blair
> 
>