[143330] trunk/dports/devel/docker-machine/Portfile

Sean Farley sean at macports.org
Sat Dec 12 14:52:57 PST 2015


Ryan Schmidt <ryandesign at macports.org> writes:

>> On Dec 12, 2015, at 11:31 AM, sean at macports.org wrote:
>> 
>> Revision
>> 143330
>> Author
>> sean at macports.org
>> Date
>> 2015-12-10 16:21:17 -0800 (Thu, 10 Dec 2015)
>> Log Message
>> 
>> docker-machine: add bash variant and fix build; closes #49952
>> Modified Paths
>> 
>> 	• trunk/dports/devel/docker-machine/Portfile
>> Diff
>> 
>> Modified: trunk/dports/devel/docker-machine/Portfile (143329 => 143330)
>> 
>
>> +    eval xinstall -m 755 [glob ${worksrcpath}/bin/*] ${destroot}${prefix}/bin/
>> +
>> +    if {[variant_isset bash_completion]} {
>> +        set completions_path ${prefix}/share/bash-completion/completions
>> +        xinstall -d ${destroot}${completions_path}
>> +        eval xinstall -m 644 [glob ${worksrcpath}/contrib/completion/bash/*.bash] ${destroot}${completions_path}/
>> +    }
>
> See port lint in trunk:
>
>
> $ port lint docker-machine
> --->  Verifying Portfile for docker-machine
> Warning: Line 37 should use the expansion operator instead of the eval procedure. Change
> Warning:     eval xinstall -m 755 [glob ${worksrcpath}/bin/*] ${destroot}${prefix}/bin/
> Warning: to
> Warning:     xinstall -m 755 {*}[glob ${worksrcpath}/bin/*] ${destroot}${prefix}/bin/
> Warning: Line 42 should use the expansion operator instead of the eval procedure. Change
> Warning:         eval xinstall -m 644 [glob ${worksrcpath}/contrib/completion/bash/*.bash] ${destroot}${completions_path}/
> Warning: to
> Warning:         xinstall -m 644 {*}[glob ${worksrcpath}/contrib/completion/bash/*.bash] ${destroot}${completions_path}/

Huzzah! Will do.


More information about the macports-dev mailing list