[133291] trunk/dports/python/py-pyxb/Portfile

[Ryan Schmidt]

> On Feb 24, 2015, at 3:04 PM, adfernandes at macports.org wrote:
> 
> Revision
> 133291
> Author
> adfernandes at macports.org
> Date
> 2015-02-24 13:04:26 -0800 (Tue, 24 Feb 2015)
> Log Message
> 
> py-pyxb: Fix for including the github portgroup, but not using it.
> Modified Paths
> 
> 	• trunk/dports/python/py-pyxb/Portfile
> Diff
> 
> Modified: trunk/dports/python/py-pyxb/Portfile (133290 => 133291)
> 
> --- trunk/dports/python/py-pyxb/Portfile	2015-02-24 20:42:18 UTC (rev 133290)
> +++ trunk/dports/python/py-pyxb/Portfile	2015-02-24 21:04:26 UTC (rev 133291)
> 
> @@ -20,6 +20,8 @@
> 
>      correspond to data structures defined by XMLSchema. In concept it is \
> 
>      similar to JAXB for Java and CodeSynthesis XSD for C++.
> 
>  
> 
> +github.setup    pabigot pyxb ${version}

The intention is that you would use:

github.setup    pabigot pyxb 1.2.4 PyXB-

at the top of the portfile, and not set the version directly. Normally you don't need to set name either, but in the case of python modules, you probably do.

> +github.tarball_from releases

This github project does not have releases; it only has tags. Downloading from tags is the default for the github portgroup, so you should remove this line.

>  homepage        https://github.com/pabigot/pyxb

This is the default value the github portgroup sets for homepage, so you should remove it.

>  distname        PyXB-${version}
>  distfiles       ${distname}.tar.gz

This is the default value MacPorts sets for distfiles, so you should remove it.

You don't need to and shouldn't set distname and worksrcdir when downloading from tags, so remove those lines.

You also should not set master_sites. The github portgroup sets it properly for you.