[131393] trunk/dports/lang/llvm-3.5
Jeremy Huddleston Sequoia
jeremyhu at macports.org
Sat Jan 10 20:21:26 PST 2015
> On Jan 10, 2015, at 18:51, Ryan Schmidt <ryandesign at macports.org> wrote:
>
>
>> On Jan 10, 2015, at 2:53 PM, jeremyhu at macports.org wrote:
>>
>> Revision
>> 131393
>> Author
>> jeremyhu at macports.org
>> Date
>> 2015-01-10 12:53:49 -0800 (Sat, 10 Jan 2015)
>> Log Message
>>
>> clang-3.5: Build fix for Leopard
>
>> Modified: trunk/dports/lang/llvm-3.5/Portfile (131392 => 131393)
>
>> - if {${subport} eq "clang-${llvm_version}" && ${os.major} <= 9} {
>> - patchfiles-append 0001-Leopard-Default-to-fno-blocks.patch
>> + if {${subport} == "clang-${llvm_version}" && ${os.major} <= 9} {
>> + patchfiles-append leopard-no-asan.patch 0001-Leopard-Default-to-fno-blocks.patch
>
> FYI string comparisons should be done with eq and ne, not == and !=. It's not really a big deal, it's just that Larry just fixed this in r129354 and now you've undone it.
Yeah, it got reverted in a copy/paste from llvm-3.3, which Larry didn't fix yet. I noticed it afterwards and thought it was cleaned up before submission, but apparently I only fixed it in 3.6 and not 3.5. I've re-rixed it.
--Jeremy
More information about the macports-dev
mailing list