[131841] trunk/dports/office

[Ryan Schmidt]

> On Jan 19, 2015, at 1:26 PM, mk at macports.org wrote:
> 
> Revision
> 131841
> Author
> mk at macports.org
> Date
> 2015-01-19 11:26:09 -0800 (Mon, 19 Jan 2015)
> Log Message
> 
> charm(-qt5): new port for qt[45] (Thanks, Rene: see issue #46575)
> Added Paths
> 
> 	• trunk/dports/office/charm/
> 	• trunk/dports/office/charm/Portfile
> 	• trunk/dports/office/charm/files/
> 	• trunk/dports/office/charm/files/adapt-to-osx-macports.patch
> 	• trunk/dports/office/charm/files/patch-CMakeFiles.patch
> Diff
> 
> Added: trunk/dports/office/charm/Portfile (0 => 131841)
> 
> --- trunk/dports/office/charm/Portfile	                        (rev 0)
> +++ trunk/dports/office/charm/Portfile	2015-01-19 19:26:09 UTC (rev 131841)
> 
> @@ -0,0 +1,63 @@
> 
> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
> +# $Id$
> +
> +PortSystem          1.0
> +PortGroup           github 1.0
> +PortGroup           cmake 1.0
> +
> +github.setup        KDAB Charm aca5faf6
> +
> +# The last release version is too old:
> +#github.setup        KDAB Charm 1.8.0
> +#github.tarball_from releases
> +
> +name                charm
> +version             1.8.0

Commit aca5faf6 is a year and a half newer than version 1.8.0. You should not claim that it is version 1.8.0.


> +if {${subport} ne "${name}-qt5"} {
> +    PortGroup       qt4 1.0
> +    conflicts       ${name}-qt5
> +    depends_build-append    port:automoc
> +    depends_lib-append      port:qt4-mac-sqlite3-plugin
> +    configure.args-append   -DWITH_QT4:BOOL=ON -DBIN_INSTALL_DIR:PATH=${qt_apps_dir}
> +}
> +
> +configure.args-append   -DCharm_VERSION="${version}-${github.version}" -DBIN_INSTALL_DIR:PATH=${qt_apps_dir}

When subport is not equal to ${name}-qt5, -DBIN_INSTALL_DIR:PATH=${qt_apps_dir} is being appended to configure.args twice.


> +post-destroot {
> +    xinstall -m 0755 -d ${destroot}${qt_apps_dir}

Could the portgroups be enhanced to create this directory, in a pre-destroot block for example?