[138188] trunk/dports/graphics/mscgen/Portfile

[Ryan Schmidt]

> On Jul 1, 2015, at 1:55 PM, adfernandes at macports.org wrote:
> 
> Revision
> 138188
> Author
> adfernandes at macports.org
> Date
> 2015-07-01 11:55:40 -0700 (Wed, 01 Jul 2015)
> Log Message
> 
> mscgen: add license and 'freetype' variant
> Modified Paths
> 
> 	• trunk/dports/graphics/mscgen/Portfile
> Diff
> 
> Modified: trunk/dports/graphics/mscgen/Portfile (138187 => 138188)
> --- trunk/dports/graphics/mscgen/Portfile	2015-07-01 18:42:16 UTC (rev 138187)
> +++ trunk/dports/graphics/mscgen/Portfile	2015-07-01 18:55:40 UTC (rev 138188)
> @@ -8,6 +8,7 @@
>  categories              graphics
>  maintainers             landonf
>  homepage                http://www.mcternan.me.uk/mscgen/
> +license                 GPL-2
>  platforms               darwin
>  
>  description             Message Sequence Chart image generator
> @@ -33,3 +34,8 @@
>  configure.env	      	GDLIB_CFLAGS='${configure.cflags}' GDLIB_LIBS='-lgd'
>  use_configure           yes
>  configure.args          --prefix=${prefix}
> +
> +variant freetype description {Support FreeType} {
> +    depends_lib-append      port:freetype
> +    configure.args-append   --with-freetype
> +}

This port already depends on the gd2 port, which depends on the freetype port, so shouldn't freetype support just be always enabled, rather than making it a variant? Wouldn't that be simpler?

Note that this is not an openmaintainer port, so you should not make changes to it without the maintainer's permission, and should instead file a ticket with your proposed patch. If you did that and Landon didn't respond, you should reference the ticket number in your commit message as usual.