[138813] trunk/dports/lang

[Ryan Schmidt]

On Jul 20, 2015, at 6:20 PM, eborisch at macports.org wrote:
> 
> Revision
> 138813
> Author
> eborisch at macports.org
> Date
> 2015-07-20 16:20:10 -0700 (Mon, 20 Jul 2015)
> Log Message
> 
> libomp: New port; LLVM project's OpenMP runtime.

> Added: trunk/dports/lang/libomp/Portfile (0 => 138813)

> +name                    libomp
> +version                 0.0
> +revision                242604

> +svn.revision            ${revision}

revision and svn.revision are not meant to be the same thing. revision is meant to be MacPorts-specific, independent of any upstream versioning. It is meant to be an integer that starts at 0 for every version of the port, and is incremented by 1 every time the port needs to be rebuilt but the upstream version has not changed.


> +notes {
> +    Use with llvm-3.7/clang-3.7 (BOTH BUILT WITH THE '-assertions' VARIANT) via:
> +      -I${prefix}/include -L${prefix}/lib -fopenmp=libomp
> +}

Variables are not interpolated within strings delimited by curly braces {}.


$ port notes libomp
libomp has the following notes:
  Use with llvm-3.7/clang-3.7 (BOTH BUILT WITH THE '-assertions' VARIANT) via:
    -I${prefix}/include -L${prefix}/lib -fopenmp=libomp


Use quotation marks "" instead if you want these occurrences of "${prefix}" replaced with the actual value of the prefix variable.


notes "
    Use with llvm-3.7/clang-3.7 (BOTH BUILT WITH THE '-assertions' VARIANT) via:
      -I${prefix}/include -L${prefix}/lib -fopenmp=libomp
"


The wording "built with the '-assertions' variant" is confusing. Did you mean: "with the assertions variant enabled" (in other words: +assertions) or "with the assertions variant disabled" (in other words: -assertions)?


If this port requires that the llvm-3.7/clang-3.7 ports are built with (or without) a particular variant, that should be enforced by using the require_active_variants proc in the active_variants 1.1 portgroup.