[137247] trunk/dports/office/zathura-plugin-djvu

Kurt Hindenburg khindenburg at macports.org
Sun Jun 7 18:01:30 PDT 2015


> On Jun 7, 2015, at 6:58 PM, Ryan Schmidt <ryandesign at macports.org> wrote:
> 
> 
>> On Jun 7, 2015, at 7:43 AM, khindenburg at macports.org wrote:
>> 
>> Revision
>> 137247
>> Author
>> khindenburg at macports.org
>> Date
>> 2015-06-07 05:43:27 -0700 (Sun, 07 Jun 2015)
>> Log Message
>> 
>> zathura-plugin-djvu: update to 0.2.4 maintainer #47868
> 
>> --- trunk/dports/office/zathura-plugin-djvu/files/patch-Makefile.diff	2015-06-07 12:33:19 UTC (rev 137246)
>> +++ trunk/dports/office/zathura-plugin-djvu/files/patch-Makefile.diff	2015-06-07 12:43:27 UTC (rev 137247)
> 
>> @@ -19,7 +17,7 @@
>> +${PLUGIN}.dylib: ${OBJECTS}
>>  	$(ECHO) LD $@
>> -	$(QUIET)${CC} -shared ${LDFLAGS} -o $@ $(OBJECTS) ${LIBS}
>> -+	$(QUIET)${CC} -Wl,-dylib_install_name,${PLUGIN}.dylib -Wl,-bundle_loader,${PREFIX}/bin/zathura -bundle ${LDFLAGS} -o $@ ${OBJECTS} ${LIBS}
>> ++	$(QUIET)${CC} -Wl,-dylib_install_name,${DESTDIR}${PLUGINDIR}/${PLUGIN}.dylib -Wl,-bundle_loader,${PREFIX}/bin/zathura -bundle ${LDFLAGS} -o $@ ${OBJECTS} ${LIBS}
>> 
>>  ${PLUGIN}-debug.so: ${DOBJECTS}
>>  	$(ECHO) LD $@
> 
> It's not correct to include ${DESTDIR} in a library's install_name. Fortunately, the linking happens at build time when DESTDIR is empty, not at destroot time when DESTDIR is set, so the port was still built correctly, and you can just remove "${DESTDIR}" from this part of the patch and not need to increase the revision.
> 

Thanks r137275
  Kurt


More information about the macports-dev mailing list