[137818] trunk/dports/math

[Ryan Schmidt]

> On Jun 20, 2015, at 12:05 PM, mk at macports.org wrote:
> 
> Revision
> 137818
> Author
> mk at macports.org
> Date
> 2015-06-20 10:05:13 -0700 (Sat, 20 Jun 2015)
> Log Message
> 
> Vc: new port thanks to René (closes #46370)

> Added: trunk/dports/math/Vc/Portfile (0 => 137818)

> +                    # Attention: the download directory changes for each release ...
> +master_sites        http://code.compeng.uni-frankfurt.de/attachments/download/183/

In this situation, I often define a variable "download_id" right after the version line, so it's clear it needs to be updated with the version.

> +post-extract        { file mkdir ${workpath}/build }
> +# standard post-arg, where to find the primary CMakeLists.txt file.
> +default configure.post_args {../${worksrcdir}}
> +default configure.dir       {${workpath}/build}
> +default build.dir           {${workpath}/build}

No particular reason to complicate this with "default", is there?. It should be equivalent in this situation to just write:


configure.post_args ../${worksrcdir}
configure.dir       ${workpath}/build
build.dir           ${configure.dir}


Also, it would be preferable to reuse that variable in the post-extract block:


post-extract {
    file mkdir ${configure.dir}
}


But in fact, all of this should really be replaced by:


cmake.out_of_source yes