[133494] trunk/dports/sysutils/pypi2port/Portfile

Mojca Miklavec mojca at macports.org
Wed Mar 4 00:47:53 PST 2015


On Wed, Mar 4, 2015 at 6:09 AM, Ryan Schmidt wrote:
>
> It looks like you also made whitespace changes to the whole file. If you make whitespace changes, you should make a separate commit with only whitespace changes. That way, such commits can be more easily ignored, and functional changes can be more easily seen and reviewed.
>
> In this case, the whitespace changes that you made don't appear to be correct.

Indeed. Please revert the whitespace to the state you had before.

You should probably also introduce an option +python27, else
    variant python34 conflicts python27
hardly makes any sense.

If you want, you can prepare a draft in a separate ticket and get some
feedback to make sure that you get the variants and automatic variant
selection right.

Mojca


More information about the macports-dev mailing list