Buildbot cruft: /opt/local/bin/mvn31

[Ryan Schmidt]

On Mar 17, 2015, at 3:24 PM, Blair Zajac wrote:
> 
> On Mar 17, 2015, at 12:39 PM, Marko Käning <MK-MacPorts at techno.ms> wrote:
> 
>> 
>> On 17 Mar 2015, at 19:58 , David Strubbe <dstrubbe at mit.edu> wrote:
>> 
>>> How about using "ls -lt" in an appropriate step of the Portfile to get this info?
>> 
>> Oh, I wasn’t aware that that could be done so easily.
>> 
>> Will try that.
>> 
>> Thanks for the hint!
> 
> Funny, I found this code in the maven3 port because of this bug:
> 
> pre-activate {
>    # Remove stray files on Mavericks buildbot
>    foreach file {bin/mvn3} {
>        set filepath ${prefix}/${file}
>        if {[file exists ${filepath}] && [registry_file_registered ${filepath}] == "0"} {
>            delete ${filepath}
>        }
>    }
> }
> 
> I’ll put this in maven31 for an hour and then remove it.

If these crufty files are present on the buildbot builders, then they are probably also present on the system of any user who installed the port. Such pre-activate blocks that clean up such cruft should be left in place until all affected users can be reasonably expected to have upgraded the port. One year is the usual amount of time we allow for that.