[134288] trunk/dports/sysutils/pidof/Portfile

[David Evans]

On 3/21/15 1:43 PM, Ryan Schmidt wrote:
> On Mar 21, 2015, at 3:37 PM, David Evans <devans at macports.org> wrote:
>> On 3/21/15 9:59 AM, ryandesign at macports.org wrote:
>>> Revision
>>> 134288
>>> Author
>>> ryandesign at macports.org
>>> Date
>>> 2015-03-21 09:59:36 -0700 (Sat, 21 Mar 2015)
>>> Log Message
>>>
>>> pidof: add universal variant
>>> Modified Paths
>>>
>>> 	• trunk/dports/sysutils/pidof/Portfile
>>> Diff
>>>
>>> Modified: trunk/dports/sysutils/pidof/Portfile (134287 => 134288)
>>>
>>> --- trunk/dports/sysutils/pidof/Portfile	2015-03-21 16:40:06 UTC (rev 134287)
>>> +++ trunk/dports/sysutils/pidof/Portfile	2015-03-21 16:59:36 UTC (rev 134288)
>>> @@ -26,6 +26,8 @@
>>>   
>>>   use_configure       no
>>>   
>>> +variant universal {}
>>> +
>>>   build.env-append    CC=${configure.cc} \
>>>                       CFLAGS="${configure.cflags}" \
>>>                       LDFLAGS="${configure.ldflags} [get_canonical_archflags ld]"
>>>
>> Ryan --
>>
>> Just for the record, can you explain why this is necessary?
>>
>> Thanks,  Dave
> MacPorts adds a universal variant by default, which works with ports using autoconf or something like it. If you use "use_configure no", you're indicating to MacPorts that this port uses something that isn't anything like autoconf, so that default universal variant goes away, and you get to program one yourself. You already did all the work: you used [get_canonical_archflags] in the right place to tell the build system what archs to use. All that was missing was a declaration of a universal variant, which causes the universal variant to show up in "port info" and "port variants", and causes [get_canonical_archflags] to return the universal archs when the universal variant is selected.
>
>
>
I was wondering what happened to the universal variant even when using 
'use_universal_variant yes' and what adding an empty universal variant 
would do to help things along, but now I know (and have verified that it 
works).

Thanks for clarifying.

Dave