[135907] trunk/dports/math/octave-database/Portfile

[Ryan Schmidt]

On May 6, 2015, at 7:53 PM, Michael Dickens wrote:

> On Wed, May 6, 2015, at 08:45 PM, Ryan Schmidt wrote:
>>> +# legacy postgresql variants; can be removed 2016-05-01
>>> +# use of < 8.3 removed as of 2.3.2.
>>> +
>>> +set legacy_postgresql_suffixes {80 81 82}
>>> +
>>> +foreach s ${legacy_postgresql_suffixes} {
>>> +    set p postgresql${s}
>>> +    eval [subst {
>>> +        variant ${p} description "Legacy variant" \
>>> +            requires postgresql${default_postgresql_suffix} {}
>>> +    }]
>>> +}
>> 
>> Why not just remove these variants? It would have the same effect. (If
>> there were binaries, it would have the added benefit that users could use
>> those binaries because they would then be using the default variants, but
>> there don't seem to be binaries of this port.)
> 
> Hmm ... I had thought I needed dummy variants to force moving to a
> provided variant. I've never tested just removing the variant, but, yes,
> now that I think about it just removing the variants should work.
> Thanks! - MLD

If the old to-be-removed variant does something that is not the default, and to do that now requires some other variant, then what you've written would be needed.

However, in your case, you want the to-be-removed variants to be changed to the default variant, in which case the old variants can just be removed and default_variants will take care of the rest.