[135940] trunk/dports/devel/gmake/Portfile

[Macports]

On May 8, 2015, at 12:20 AM, Ryan Schmidt <ryandesign at macports.org> wrote:

> 
>> On May 7, 2015, at 9:28 AM, mf2k at macports.org wrote:
>> 
>> Revision
>> 135940
>> Author
>> mf2k at macports.org
>> Date
>> 2015-05-07 07:28:21 -0700 (Thu, 07 May 2015)
>> Log Message
>> 
>> gmake: Add guile variant. (#45527)
>> Modified Paths
>> 
>> 	• trunk/dports/devel/gmake/Portfile
>> Diff
>> 
>> Modified: trunk/dports/devel/gmake/Portfile (135939 => 135940)
>> 
>> --- trunk/dports/devel/gmake/Portfile	2015-05-07 14:24:01 UTC (rev 135939)
>> +++ trunk/dports/devel/gmake/Portfile	2015-05-07 14:28:21 UTC (rev 135940)
>> @@ -10,7 +10,7 @@
>> description     GNU Make
>> long_description \
>>     Make is a tool which controls the generation of executables and     \
>> -    other non-source files of a program from the program's source files.\
>> +    other non-source files of a program from the program`s source files.\
> 
> Did you really mean to replace an apostrophe (which was the correct punctuation mark) with a backtick (which isn't)?
> 
> 
>> @@ -33,5 +33,10 @@
>> configure.args  --program-prefix=g \
>>                 --without-guile
>> 
>> +variant guile description "Enable GNU Guile extensions" {
>> +    depends_lib-append  port:guile
>> +    configure.args  --program-prefix=g --with-guile
>> +}
> 
> You should not override the configure.args in a variant. This is just inviting problems to occur later when someone updates the main configure.args and doesn't realize they're meant to update the configure.args in this variant as well.
> 
> Instead, just replace the one arg you care about with the new arg:
> 
> configure.args-replace --without-guile --with-guile

See <https://trac.macports.org/ticket/45527#comment:14>


Cheers!
Frank