patch feedback:depends_test - port test - port lint -append

Kurt Hindenburg khindenburg at
Sun Sep 20 11:50:29 PDT 2015


> On Sep 4, 2015, at 3:02 PM, Joshua Root <jmr at> wrote:
> On 2015-9-4 07:43 , Kurt Hindenburg wrote:
>> Hi,
>>  Can I get some feedback on these patches?
>> - add depends_test
> r+
> LGTM. My one concern would be that end users may not want irrelevant (to
> them) test deps showing up in depends:, rdeps and so forth, but we
> should come up with a general solution to that, not just omit them.

committed r140488

>> - port test stops if is
>> not yes
> r-
> This shouldn't be checked in portmain but rather somewhere higher up in
> the vicinity of mportexec, where the deps are being computed and the
> target is known.

A new patch attached to <>

>> - port lint check when should use
>> -append
> r-
> Overriding the deps set by a portgroup is not always incorrect.

Do you mean to say that there are times that the Portfile should override the PortGroup?  Do you think changing this lint to a warning suggesting they should verify if they should use ‘-append’ ?


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the macports-dev mailing list