[147562] branches/portgroups-selector/base/src/port/port.tcl

Rainer Müller raimue at macports.org
Fri Apr 8 04:00:08 PDT 2016


On 2016-04-08 02:06, raimue at macports.org wrote:
> Revision: 147562
>           https://trac.macports.org/changeset/147562
> Author:   raimue at macports.org
> Date:     2016-04-07 17:06:46 -0700 (Thu, 07 Apr 2016)
> Log Message:
> -----------
> Add new pseudo-port selectors for port groups
> 
> Modified Paths:
> --------------
>     branches/portgroups-selector/base/src/port/port.tcl
> 
> Modified: branches/portgroups-selector/base/src/port/port.tcl
> ===================================================================
> --- branches/portgroups-selector/base/src/port/port.tcl	2016-04-08 00:01:31 UTC (rev 147561)
> +++ branches/portgroups-selector/base/src/port/port.tcl	2016-04-08 00:06:46 UTC (rev 147562)

> @@ -1322,6 +1327,10 @@
>          ^(revision):(.*)         -
>          ^(subport):(.*)          -
>          ^(subports):(.*)         -
> +        ^(group):(.*)            -
> +        ^(groups):(.*)           -
> +        ^(portgroup):(.*)        -
> +        ^(portgroups):(.*)       -
>          ^(license):(.*)          { # Handle special port selectors
>              advance

Here I added support for all of these forms:
  group:foo
  groups:foo
  portgroup:foo
  portgroups:foo
It feels kind of excessive to have four keywords for the same thing...

We usually refer to them as "port groups" (which is also the internal
name), but the shorter "groups" seems clear enough. The "port*" prefix
seems a bit redundant.

Any opinions?

Rainer


More information about the macports-dev mailing list