[150874] trunk/dports/lang/python32

Lawrence Velázquez larryv at macports.org
Mon Aug 1 11:39:24 PDT 2016


> On Aug 1, 2016, at 2:44 AM, ionic at macports.org <mailto:ionic at macports.org> wrote:
> 
> Revision
> 150874 <https://trac.macports.org/changeset/150874>Author
> ionic at macports.org <mailto:ionic at macports.org>Date
> 2016-07-31 23:44:08 -0700 (Sun, 31 Jul 2016)
> Log Message
> 
> python32: refresh patches, rename a few with "wrong" names.

> Added Paths
> 
> trunk/dports/lang/python32/files/patch-Lib-distutils-util.py_Mac-BuildScript-build-installer.py-yosemite_python_fixes.diff <x-msg://14/#trunkdportslangpython32filespatchLibdistutilsutilpy_MacBuildScriptbuildinstallerpyyosemite_python_fixesdiff>
> trunk/dports/lang/python32/files/patch-Lib-site.py-omit_local_site_packages.diff <x-msg://14/#trunkdportslangpython32filespatchLibsitepyomit_local_site_packagesdiff>
> trunk/dports/lang/python32/files/patch-configure_configure.ac-yosemite_configure_fixes.diff <x-msg://14/#trunkdportslangpython32filespatchconfigure_configureacyosemite_configure_fixesdiff>
> Removed Paths
> 
> trunk/dports/lang/python32/files/omit-local-site-packages.patch <x-msg://14/#trunkdportslangpython32filesomitlocalsitepackagespatch>
> trunk/dports/lang/python32/files/yosemite-configure-fixes.patch <x-msg://14/#trunkdportslangpython32filesyosemiteconfigurefixespatch>
> trunk/dports/lang/python32/files/yosemite-python-fixes.patch <x-msg://14/#trunkdportslangpython32filesyosemitepythonfixespatch>
Not to pick on you, Mihai, but have we ever considered getting rid of (or at least revising) the guideline that implies that these new, sprawling, indecipherable patch names are somehow more "correct" than the old ones? I have never understood the point of including the name(s) of the modified file(s) in the name of the patch itself, when this information is *already inside the patch*.

And these aren't even the worst: Many patches are just named after the files they modify, with no information about their purpose. I don't think I should have to resort to version control to get the first inkling of a patch's purpose.

vq
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.macosforge.org/pipermail/macports-dev/attachments/20160801/20989e64/attachment.html>


More information about the macports-dev mailing list