[151215] contrib/mp-buildbot

Mojca Miklavec mojca at macports.org
Wed Aug 10 11:25:22 PDT 2016

On 10 August 2016 at 20:17, Lawrence Velázquez wrote:
> --- contrib/mp-buildbot/mpbb 2016-08-10 16:13:48 UTC (rev 151214)
> +++ contrib/mp-buildbot/mpbb 2016-08-10 18:09:29 UTC (rev 151215)
> @@ -77,6 +79,10 @@    between builds. Your MacPorts installation in --prefix
> needs to be able to
>     access this location. Defaults to your current directory, or
>     /tmp/mp-buildbot if \$PWD isn't set.
> +
> + --logdir LOGDIR
> +   A temporary folder for storing log files to be read by the master.
> Defaults to
> +   WORKDIR/logs.
>  EOF
> This description is not true in the current implementation because the value
> of ${option_logdir} does not track the value of ${option_workdir}. That is,
> if mpbb is invoked with --workdir FOO, ${option_logdir} will not have the
> value FOO/logs. To make this work, you'd have to set option_logdir after the
> option parsing.

Thanks a lot for catching this.

Would you be willing to fix this properly before I make a bunch of
other mistakes? In particular I'm not absolutely sure how to handle
cases like this one in an elegant way:
    ./mpbb something --logdir /tmp/a --workdir /tmp/b
This should keep logdir at /tmp/a.

Alternatively logdir could simply remain hardcoded as
${option_workdir}/logs. There's no need for an extra layer of
complexity that doesn't really serve anyone.

To be honest I'm not even sure if this is the best possible approach,
so other suggestions (or simply fixes) to improve the whole commit are
also welcome.


More information about the macports-dev mailing list