[151264] contrib/mp-buildbot/mpbb-install-port

[Clemens Lang]

Hi Mojca,

On Wed, Aug 10, 2016 at 11:48:51PM -0700, mojca at macports.org wrote:
> Revision: 151264
>           https://trac.macports.org/changeset/151264
> Author:   mojca at macports.org
> Date:     2016-08-10 23:48:51 -0700 (Wed, 10 Aug 2016)
> Log Message:
> -----------
> mp-buildbot/install-port: add basic statistics and main.log (not sure if useful, port -d is more verbose)
> 
> +    # TODO: printing statistics (and installing the port + dependencies)
> +    #       only makes sense when the port hasn't been installed previously
> +    # log: statistics
> +    echo "time:    $(($time_stop - $time_start))s" >> "$log_port_stats"

Inside $(( )), dollar signs are not required for variables.
$((time_stop - time_start)) works just fine.

> +    # log: main.log
> +    local port_mainlog=$("${option_prefix}/bin/port" logfile "${option_port}")
> +    if [ -f $port_mainlog ]; then

$port_mainlog should be quoted here.


-- 
Clemens