py-pyqt4: fix for the depends_lib reset caused by the Python PortGroup

René J.V. Bertin rjvbertin at gmail.com
Sat Dec 17 17:22:16 CET 2016


On Saturday December 17 2016 17:59:27 Marko Käning wrote:

Hi,

> René, I missed this double and now even triple dependency to qt4-mac completely.

Josh: if you look at your "before" output you'll see that there was already a double depspec:

> > Library Dependencies: qt4-mac, python27, py27-sip, qt4-mac, dbus-python27
> > Library Dependencies: qt4-mac, python27, qt4-mac, py27-sip, qt4-mac, dbus-python27

> Josh, which stub port do you mean? dbus-python##? If so, why is it unneeded and why had it been there before already.

I think he means port:py-pyqt4 .

> What do you suggest to recover from this mess?

I'll figure out a solution ASAP. The triple qt4-mac depspec must be because Marko's commit didn't remove the explicit depspec on line 82 (which my patch did remove, IIRC).

I see that we made the same error with port:py-pyqt5, btw. 

R.

> 		
> On 17 Dec 2016, at 15:11 , Joshua Root <jmr at macports.org> wrote:
> 
> > <https://github.com/macports/macports-ports/commit/6982d654f53f45585e157ece80ee3ed698cc5d33>
> > 
> > Before this change:
> > 
> > % port deps py\*-pyqt4
> > Full Name: py-pyqt4 @4.11.4_4
> > Build Dependencies:   pkgconfig
> > Library Dependencies: py27-pyqt4
> > --
> > Full Name: py27-pyqt4 @4.11.4_4
> > Build Dependencies:   pkgconfig
> > Library Dependencies: qt4-mac, python27, py27-sip, qt4-mac, dbus-python27
> > --
> > Full Name: py34-pyqt4 @4.11.4_4
> > Build Dependencies:   pkgconfig
> > Library Dependencies: qt4-mac, python34, py34-sip, qt4-mac, dbus-python34
> > --
> > Full Name: py35-pyqt4 @4.11.4_4
> > Build Dependencies:   pkgconfig
> > Library Dependencies: qt4-mac, python35, py35-sip, qt4-mac, dbus-python35
> > 
> > Afterwards:
> > 
> > % port deps py\*-pyqt4
> > Full Name: py-pyqt4 @4.11.4_4
> > Build Dependencies:   pkgconfig
> > Library Dependencies: py27-pyqt4, qt4-mac
> > --
> > Full Name: py27-pyqt4 @4.11.4_4
> > Build Dependencies:   pkgconfig
> > Library Dependencies: qt4-mac, python27, qt4-mac, py27-sip, qt4-mac,
> >                      dbus-python27
> > --
> > Full Name: py34-pyqt4 @4.11.4_4
> > Build Dependencies:   pkgconfig
> > Library Dependencies: qt4-mac, python34, qt4-mac, py34-sip, qt4-mac,
> >                      dbus-python34
> > --
> > Full Name: py35-pyqt4 @4.11.4_4
> > Build Dependencies:   pkgconfig
> > Library Dependencies: qt4-mac, python35, qt4-mac, py35-sip, qt4-mac,
> >                      dbus-python35
> > 
> > This adds a (second) duplicate dependency to the subports and an unneeded one to the stub port.
> > 
> > - Josh
> 



More information about the macports-dev mailing list