Guidelines about trac tickets and pull requests

[John Patrick]

>From a users point of view, it's not clear what I should be doing and
how Ticket's link with Pull Requests and vs versa? The MacPorts Guide
still mostly talks about patches and trac, it doesn't feel like it's
been update with how git should be used.

At the moment I;
1) raise a trac ticket
2) create/rename the branch based upon the trac number
3) push that to my fork
4) open pull request and add link to trac
5) update trac ticket with pull request url

I'm use to Git and Jira where if the git commit message contains a
valid jira ticket, jira can be automatically update the ticket
details. Also it's strange that pull requests are not merged, as this
would help give credit to people supplying pull requests as at the
moment your asked to close your pull request.

John








On 29 December 2016 at 18:18, Mojca Miklavec <mojca at macports.org> wrote:
> Hi,
>
> I believe that we need some written guidelines about opening trac
> tickets and pull request. Many people now open both at the same time.
> That's not as bad when they are at least referenced properly (and
> annoying when they are not), but it probably doesn't serve anyone to
> have both.
>
> (I believe that it might still make sense to open a pull request
> referencing an existing bug report to simplify reviews or when
> multiple commits are needed.)
>
> But we should write those things down somewhere, perhaps at Ticket
> guidelines (https://guide.macports.org/#project.tickets).
>
> Mojca