[149178] trunk/dports/audio/pulseaudio/Portfile

[Ryan Schmidt]

> On Jun 4, 2016, at 4:56 PM, ionic at macports.org wrote:
> 
> Revision
> 149178
> Author
> ionic at macports.org
> Date
> 2016-06-04 14:56:53 -0700 (Sat, 04 Jun 2016)
> Log Message
> 
> pulseaudio: add esound variant. Revbump.
> Modified Paths
> 	• trunk/dports/audio/pulseaudio/Portfile
> Diff
> Modified: trunk/dports/audio/pulseaudio/Portfile (149177 => 149178)
> --- trunk/dports/audio/pulseaudio/Portfile	2016-06-04 21:26:47 UTC (rev 149177)
> +++ trunk/dports/audio/pulseaudio/Portfile	2016-06-04 21:56:53 UTC (rev 149178)
> @@ -9,7 +9,7 @@
>  
>  name                pulseaudio
>  version             8.0
> -revision            0
> +revision            1
>  license             LGPL-2.1
>  categories          audio
>  maintainers         ionic openmaintainer
> @@ -143,6 +143,11 @@
>      patchfiles-append       patch-src_daemon_caps.c-enable-root.diff
>  }
>  
> +variant esound description {Enable optional esound emulation support.} {
> +    configure.args-replace  --disable-esound \
> +                            --enable-esound
> +}

Don't change it now, but why the revbump? Forcing the users to rebuild the port will not change anything.

Had you added a new default variant, that would warrant a revbump, because rebuilding would cause users who hadn't selected that variant before to now have it selected.

Out of curiosity, since this variant doesn't add any dependencies, why make it a variant at all? Why not enable esound emulation all the time?