Pull Requests for Work in Progress (WIP)

Sterling Smith smithsp at fusion.gat.com
Thu Nov 3 10:57:00 PDT 2016


On Nov 3, 2016, at 10:47AM, Rainer Müller <raimue at macports.org> wrote:

> On 2016-11-03 17:49, Sterling Smith wrote:
>> The main question of procedure is: Should the main macports repo be
>> used for proposing review of work in progress via pull requests?  If
>> not, what is the proposed method?
> 
> I propose you put your changes on a branch, add the compare URL to a
> ticket or send an email to macports-dev.
> 
> In the case you referred to, this would be:
> 
> https://github.com/mkae/macports-ports/compare/master...mkae:qtcurve_upgrade-for-Qt5
> 
The downside (as I see it) of using the compare URL, as opposed to a full pull request, is that line by line comments are not available.

-Sterling



More information about the macports-dev mailing list