[macports-ports] branch master updated: databases/percona: Fixed percona download URL to use version_branch again. Removed $Id$ tag. Closes; #62 Closes: https://trac.macports.org/ticket/52664 Closes: https://trac.macports.org/ticket/52946

Bradley Giesbrecht pixilla at macports.org
Tue Nov 29 01:42:50 CET 2016


> On Nov 28, 2016, at 4:20 PM, Lawrence Velázquez <larryv at macports.org> wrote:
> 
> Hi,
> 
>> On Nov 28, 2016, at 7:13 PM, Roger Ward <rogerw at gmail.com> wrote:
>> 
>> Bradley Giesbrecht (pixilla) pushed a commit to branch master
>> in repository macports-ports.
>> 
>> 
>> https://github.com/macports/macports-ports/commit/2f43f23a572b62018bd0e4c0182df99f1a9bcd34
>> 
>> The following commit(s) were added to refs/heads/master by this push:
>> 
>>      new 2f43f23  databases/percona: Fixed percona download URL to use version_branch again. Removed $Id$ tag. Closes; #62 Closes: https://trac.macports.org/ticket/52664 Closes: https://trac.macports.org/ticket/52946
>> 2f43f23 is described below
>> 
>> 
>> commit 2f43f23a572b62018bd0e4c0182df99f1a9bcd34
>> 
>> Author: Roger Ward <rogerw at gmail.com
>> >
>> AuthorDate: Thu Nov 24 06:40:55 2016 -0700
>> 
>> 
>>     databases/percona:
>> 
>>     Fixed percona download URL to use version_branch again.
>> 
>>     Removed $Id$ tag.
>> 
>>     Closes; #62
>> 
>>     Closes: https://trac.macports.org/ticket/52664
>>     Closes: https://trac.macports.org/ticket/52946
> In future commit messages, please leave the second line blank.
> 
> vq

Thanks for the comment Lawrence.

In IRC I wasn’t sure how to read Clemens comment:
"Yes, Closes: $ticketlink, due to the length on their own lines, preferably”

I thought maybe a single long line commit message was not preferable.

Do you literally mean the second line blank, like this:
“
databases/percona:

    Fixed percona download URL to use version_branch again.
    Removed $Id$ tag.
    Closes: #62
    Closes: https://trac.macports.org/ticket/52664
    Closes: https://trac.macports.org/ticket/52946
“

Is it a good idea to start the comment with a reference the port dir or effected ports?


Regards,
Bradley Giesbrecht (pixilla)




More information about the macports-dev mailing list