[152440] trunk/dports/net

[Eric A. Borisch]

On Friday, September 9, 2016, Ryan Schmidt <ryandesign at macports.org> wrote:

>
> > On Sep 8, 2016, at 11:28 PM, eborisch at macports.org <javascript:;> wrote:
> >
> > Revision
> > 152440
> > Author
> > eborisch at macports.org <javascript:;>
> > Date
> > 2016-09-08 21:28:04 -0700 (Thu, 08 Sep 2016)
> > Log Message
> >
> > zabbix3: New port.
>
>
> > Added Paths
> >
> >       • trunk/dports/net/zabbix3/
>
>
> > +                    --with-gnutls=/opt/local \
> > +                    --enable-ipv6
>
> Surely that should be "${prefix}" not "/opt/local"?
>
>
> > +        eval xinstall -m 755 -W ${worksrcpath}/database/${DBFILES} \
> > +            data.sql images.sql schema.sql \
> > +            ${destroot}${prefix}/share/zabbix/scripts
>
> It doesn't look like this needs eval -- I don't see a list. If a list were
> being used, the expansion operator ("{*}") should be used instead of eval.
>

Yes on both parts. Thanks for catching those; I'll clean them up.

 - Eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.macosforge.org/pipermail/macports-dev/attachments/20160909/39d5eff2/attachment.html>