[152743] trunk/dports/_resources/port1.0/group

[Ryan Schmidt]

> On Sep 16, 2016, at 9:06 AM, Rainer Müller <raimue at macports.org> wrote:
> 
> On 2016-09-16 01:09, ryandesign at macports.org wrote:
>> Revision: 152743
>>          https://trac.macports.org/changeset/152743
>> Author:   ryandesign at macports.org
>> Date:     2016-09-15 16:09:26 -0700 (Thu, 15 Sep 2016)
>> Log Message:
>> -----------
>> Portgroups: replace "Mac OS X" and "OS X" with "macOS"
> 
>> Modified: trunk/dports/_resources/port1.0/group/xcodeversion-1.0.tcl
>> ===================================================================
>> --- trunk/dports/_resources/port1.0/group/xcodeversion-1.0.tcl	2016-09-15 23:06:35 UTC (rev 152742)
>> +++ trunk/dports/_resources/port1.0/group/xcodeversion-1.0.tcl	2016-09-15 23:09:26 UTC (rev 152743)
>> @@ -38,7 +38,7 @@
>> #   minimum_xcodeversions   {darwin_major minimum_xcodeversion}
>> #
>> # where darwin_major is the major version of the underlying Darwin OS (e.g. 9
>> -# for Mac OS X 10.5 Leopard) and minimum_xcodeversion is the minimum version
>> +# for macOS Leopard) and minimum_xcodeversion is the minimum version
>> # of Xcode the port requires (e.g. 3.1).
> 
> I would keep this as Mac OS X 10.5 Leopard, the name does not change
> retroactively.

I suppose that's an open question. Previously, I've tried to use the OS marketing name as it was when that OS version was released. Now, I'm thinking we should always use the current marketing name. Do we have any guidance from Apple on what they want people to do?

> The version number is usually also helpful to get the
> "10.X" to "darwin Y" mapping right.

Yes but I didn't want to go into a long explanation in that comment.

>> options minimum_xcodeversions
>> @@ -57,7 +57,7 @@
>>                     return -code error "unable to find Xcode"
>>                 }
>>                 if {[vercmp ${xcodeversion} ${minimum_xcodeversion}] < 0} {
>> -                    ui_error "On Mac OS X ${macosx_version}, ${name} ${version} requires Xcode ${minimum_xcodeversion} or later but you have Xcode ${xcodeversion}."
>> +                    ui_error "On macOS ${macosx_version}, ${name} @${version} requires Xcode ${minimum_xcodeversion} or later but you have Xcode ${xcodeversion}."
> 
> Why drop the foo @1.0 syntax that we use at so many other places to
> specify a port version?

I didn't drop it; I started using it, finally, in this portgroup.