[153356] trunk/dports/gnome/gnucash

[Ryan Schmidt]

> On Sep 29, 2016, at 3:16 AM, dports at macports.org wrote:
> 
> Revision
> 153356
> Author
> dports at macports.org
> Date
> 2016-09-29 01:16:39 -0700 (Thu, 29 Sep 2016)
> Log Message
> 
> gnucash: fix +python27 variant (#43254)
> Modified Paths
> 
> 	• trunk/dports/gnome/gnucash/Portfile
> Removed Paths
> 
> 	• trunk/dports/gnome/gnucash/files/patch-configure-python.diff
> Diff
> 
> Modified: trunk/dports/gnome/gnucash/Portfile (153355 => 153356)
> 
> --- trunk/dports/gnome/gnucash/Portfile	2016-09-29 07:45:33 UTC (rev 153355)
> +++ trunk/dports/gnome/gnucash/Portfile	2016-09-29 08:16:39 UTC (rev 153356)
> 
> @@ -88,10 +88,16 @@
> 
>  
> 
>  post-patch {
> 
>      xinstall -m 755 ${filespath}/autogen.sh ${worksrcpath}
> 
> +    system "cd ${worksrcpath} && ./autogen.sh"

You should use system's -W argument, rather than manually running cd:

system -W ${worksrcpath} "./autogen.sh"

However, you can't run autogen.sh in post-patch; the dependencies are not guaranteed to have been installed until the configure phase starts.


> +    if {[variant_isset python27]} {
> +        # Fix python exec_prefix
> +        reinplace "s|\\(PYTHON_EXEC_PREFIX=\\).*$|\\1${frameworks_dir}/Python.framework/Versions/2.7/|" \
> +            ${worksrcpath}/configure
> +        reinplace "s|\\(PYTHON_PREFIX=\\).*$|\\1${frameworks_dir}/Python.framework/Versions/2.7/|" \
> +            ${worksrcpath}/configure
> +    }
> 
>  }
> 
>  
> 
> -configure.cmd     ./autogen.sh && ./configure
> -
> 
>  configure.args    --disable-dependency-tracking \
> 
>                    --disable-aqbanking \
> 
>                    --disable-ofx \
> 
> @@ -126,12 +132,14 @@
> 
>  
> 
>  default_variants +ofx +hbci
> 
>  
> 
> -# variant python27 description {Install Python bindings for Python 2.7} {
> -#     #patchfiles-append patch-configure-python.diff
> -#     depends_lib-append port:python27
> -#     configure.args-append --enable-python
> -#     configure.python ${prefix}/bin/python2.7
> -# }
> 
> +variant python27 description {Install Python bindings for Python 2.7} { 
> +    depends_lib-append  port:python27 
> +    set python_bindir ${frameworks_dir}/Python.framework/Versions/2.7/bin/ 
> +    configure.args-append --enable-python \
> +                          PYTHON_EXTRA_LDFLAGS=\"\`${python_bindir}/python2.7-config --ldflags\`\" \
> +                          PYTHON_CPPFLAGS=\"\`${python_bindir}/python2.7-config --cflags\`\" 
> +    configure.python    ${python_bindir}/python2.7 
> +} 
> 
>  
> 
>  post-activate {
> 
>      system "${prefix}/bin/gtk-update-icon-cache -f -t ${prefix}/share/icons/hicolor"