To force-push or not to force-push
Helmut K. C. Tessarek
tessarek at evermeet.cx
Wed Apr 19 19:30:16 UTC 2017
On 2017-04-19 08:43, Rainer Müller wrote:
> For pull requests, you are not pushing to the MacPorts repository,
> but to the repository of the user who opened the pull request...
Yes, but the documentation is not clear about this. It does not say that
the project is ok with force-pushing in PRs. Some projects are not ok
with it and require you to close the PR and open a new one (or to add
commits to change previous ones).
> It seems like it would be easier to correct these kind of things if
> we allowed squashing commits in the GitHub UI when accepting a pull
> request, instead of only allowing rebase.
Yep, but it's also more error prone. You could easily squash commits
which are not supposed to be squashed.
Cheers,
K. C.
--
regards Helmut K. C. Tessarek
lookup http://pool.sks-keyservers.net for KeyID 0xC11F128D
/*
Thou shalt not follow the NULL pointer for chaos and madness
await thee at its end.
*/
More information about the macports-dev
mailing list