[macports-ports] branch master updated: qgis3: enable Python bindings and processing module

[Ryan Schmidt]

On Dec 7, 2017, at 01:38, Vincent wrote:

> Vincent (Veence) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/b35a0526cd7fb7e0c897d1c92d08ddea6e3232af
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new b35a052  qgis3: enable Python bindings and processing module
> 
> b35a052 is described below
> 
> 
> commit b35a0526cd7fb7e0c897d1c92d08ddea6e3232af
> 
> Author: Veence
> AuthorDate: Thu Dec 7 08:38:52 2017 +0100
> 
> 
>     qgis3: enable Python bindings and processing module

It sounds like this changes the files that get installed. If so, increase the port's revision.

Note that this port doesn't build on any of the buildbot workers due to https://trac.macports.org/ticket/55480



> --- a/gis/qgis3/Portfile
> +++ b/gis/qgis3/Portfile
> @@ -24,7 +24,8 @@ use_parallel_build  no
>  homepage            http://www.qgis.org/
>  patchfiles          patch-app_info_plist_in.diff \
> -                    patch-CMakelists_txt.diff
> +                    patch-CMakelists_txt.diff \
> +                    patch-FindPyQt5_py.diff
>  
>  checksums           rmd160  a3d9d07479c61da4ce96e6e645eaf9a23c294c65 \
>                      sha256  61d69356a7c53b201d733c1eb6e366c13f181bc022a7429fc17e38418e07bec0
> @@ -48,6 +49,8 @@ depends_lib-append  port:libiconv \
>                      port:qt5-qtwebkit \
>                      port:qt5-qtscript \
>                      port:qt5-sqlite-plugin \
> +                    port:qt5-qtscxml \
> +                    port:qt5-qtxmlpatterns \
>                      port:qca-qt5 \
>                      port:qca-qt5-ossl \
>                      port:qtkeychain-qt5 \
> @@ -66,6 +69,9 @@ post-patch {
>      reinplace -E "s|@@@|${prefix}|g" \
>          ${worksrcpath}/mac/app.info.plist.in
>  
> +    reinplace -E "s|@@@|${frameworks_dir}|g" \
> +        ${worksrcpath}/cmake/FindPyQt5.py
> +


> +--- cmake/FindPyQt5.py.orig	2017-12-07 07:54:53.000000000 +0100
> ++++ cmake/FindPyQt5.py	2017-12-07 07:56:08.000000000 +0100
> +@@ -38,7 +38,7 @@
> +     import sipconfig # won't work for SIP v5
> +     import os.path
> +     cfg = sipconfig.Configuration()
> +-    sip_dir = cfg.default_sip_dir
> ++    sip_dir = "@@@/Python.framework/Versions/3.6/share/sip"


It's confusing that you're using "@@@" to mean one thing in one file and another thing in another file. I recommend using named placeholders like most other ports do, where the same placeholder always means the same thing in any file. Other ports commonly use the placeholders @PREFIX@ and @FRAMEWORKS_DIR at .

It looks like you've hardcoded python version 3.6. What if the user selects one of the other python variants?

Is this commit related to https://trac.macports.org/ticket/55479?