[macports-ports] 03/06: cxx11 PG: do not force the use of depends_lib-append

[Marcus Calhoun-Lopez]

On Mon, Dec 4, 2017 at 10:23 PM, Ryan Schmidt <ryandesign at macports.org> wrote:
>
> On Oct 21, 2017, at 23:10, Marcus Calhoun-Lopez wrote:
>
>> Marcus Calhoun-Lopez (MarcusCalhoun-Lopez) pushed a commit to branch master
>> in repository macports-ports.
>>
>>
>> https://github.com/macports/macports-ports/commit/9ae6b8e85dc534d9d23144f0664b4d3790f35187
>>
>> commit 9ae6b8e85dc534d9d23144f0664b4d3790f35187
>>
>> Author: Marcus Calhoun-Lopez
>> AuthorDate: Sat Oct 21 21:02:00 2017 -0700
>>
>>
>>     cxx11 PG: do not force the use of depends_lib-append
>>
>> ---
>>  _resources/port1.0/group/cxx11-1.1.tcl | 9 +++++++--
>>  1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/_resources/port1.0/group/cxx11-1.1.tcl b/_resources/port1.0/group/cxx11-1.1.tcl
>> index df41a74..f9b7534 100644
>> --- a/_resources/port1.0/group/cxx11-1.1.tcl
>> +++ b/_resources/port1.0/group/cxx11-1.1.tcl
>> @@ -44,8 +44,13 @@ if {${cxx_stdlib} eq "libstdc++" } {
>>      # see https://trac.macports.org/ticket/53194
>>      configure.cxx_stdlib macports-libstdc++
>>
>> -    # see https://trac.macports.org/ticket/54766
>> -    depends_lib-append port:libgcc
>> +    proc register_gcc_dependents {} {
>> +        global os.major
>> +        # see https://trac.macports.org/ticket/54766
>> +        depends_lib-append port:libgcc
>> +    }
>> +    # do not force all Portfiles to switch from depends_lib to depends_lib-append
>> +    port::register_callback register_gcc_dependents
>
> Shouldn't it be "dependencies" not "dependents"?
>
> Also, why `global os.major`? It's not used...
os.major is used in line 52 [1].

>
> The proc name should probably begin with "cxx11." to avoid possible collisions with other portgroups.
>
> How about just "proc cxx11.add_dependencies"?
>
The procedure rename was made in a recent commit [2].

-Marcus

[1] https://github.com/macports/macports-ports/blob/7e49f996735b9601240155afb9e75ac9acfa821c/_resources/port1.0/group/cxx11-1.1.tcl#L52
[2] https://github.com/macports/macports-ports/commit/7e49f996735b9601240155afb9e75ac9acfa821c