[macports-ports] branch master updated: supertuxkart: allow build on 10.7 and 10.8

[Ryan Schmidt]

On Dec 25, 2017, at 16:06, Ken wrote:

> Ken (kencu) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/5d8fbbdc86dbb15c908fd4a076d06ec9004d1421
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new 5d8fbbd  supertuxkart: allow build on 10.7 and 10.8
> 
> 5d8fbbd is described below
> 
> 
> commit 5d8fbbdc86dbb15c908fd4a076d06ec9004d1421
> 
> Author: Ken Cunningham
> AuthorDate: Mon Dec 25 14:06:20 2017 -0800
> 
>     supertuxkart: allow build on 10.7 and 10.8
>     
>     app can run on these platforms, with some
>     non-fatal errors noted. adjust Info.plist
>     to macosx_deployment_target
> 
> ---
>  games/supertuxkart/Portfile | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/games/supertuxkart/Portfile b/games/supertuxkart/Portfile
> index 758b977..aeb29cb 100644
> --- a/games/supertuxkart/Portfile
> +++ b/games/supertuxkart/Portfile
> @@ -26,15 +26,24 @@ checksums           md5     8de5455b8fdbb92679e302b76c9041cf \
>  master_sites        sourceforge:project/${name}/SuperTuxKart/${version}
>  
>  # 10.6 SDK does not have sufficient opengl capability to build this
> -# 10.7+ SDK can build this port if the cxx11 1.1 PortGroup is used
> -# but the application crashes on launch in the irrlicht code
> -if { ${os.platform} eq "darwin" && ${os.major} < 13 } {
> +# if building with 10.7 SDK on 10.6, errors regarding missing symbols
> +# are noted when running the app
> +if { ${os.platform} eq "darwin" && ${os.major} < 10 } {
>      pre-fetch {
> -        ui_error "${name} requires OS X 10.9 or later"
> +        ui_error "${name} requires OS X 10.7 or later"
>          return -code error "incompatible OS version"
>      }
>  }

This doesn't match now. The error message says it needs 10.7 or later, but the port allows installation on 10.6 or later. Which is it?

If it builds on 10.6, does it need the 10.7 SDK to do so? If so, the port should enforce that. See the libsdl2 port for an example of how to do that.


> +# 10.7+ SDK can build this if the cxx11 1.1 PortGroup is used
> +# some errors occur when running, but the app can run on 10.7
> +if { ${os.platform} eq "darwin" && ${os.major} < 13 } {
> +    PortGroup  cxx11   1.1
> +    post-extract {
> +        reinplace "s|10.9|${macosx_deployment_target}|g" ${worksrcpath}/data/SuperTuxKart-Info.plist
> +    }

Patching should happen in the patch phase, not the extract phase. You want to be able to run "sudo port extract ..." and see the unmodified files.

You should escape the "." in that regular expression by preceding it with a backslash: s|10\.9|...