[macports-ports] branch master updated: lang/ruby25: new port (#55588)

[Ryan Schmidt]

On Dec 26, 2017, at 08:16, kimura wataru wrote:

> kimura wataru (kimuraw) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/98738d1acf489a1c771064b37529118a8355efe1
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new 98738d1  lang/ruby25: new port (#55588)
> 
> 98738d1 is described below
> 
> 
> commit 98738d1acf489a1c771064b37529118a8355efe1
> 
> Author: kimura wataru
> AuthorDate: Tue Dec 26 23:08:40 2017 +0900
> 
> 
>     lang/ruby25: new port (#55588)

Now that we've moved MacPorts to GitHub, "#55588" in a commit message refers to GitHub pull request 55588, which is not what you meant. To refer to Trac ticket 55588 in a commit message, use the full URL of the ticket.

Place it on a line by itself, preceded by "Closes: ", and Trac will automatically close that ticket after the commit. For example:


ruby25: New port, version 2.5.0

Closes: https://trac.macports.org/ticket/55588




>     https://www.ruby-lang.org/en/news/2017/12/25/ruby-2-5-0-released/
> 
> ---
>  lang/ruby25/Portfile     | 118 +++++++++++++++++++++++++++++++++++++++++++++++


> +maintainers         kimuraw openmaintainer

When you have a moment, please add your GitHub handle (preceded by "@") to the maintainers line of your ports. Group your MacPorts handle and your GitHub handle in curly braces to show that they represent the same person. For example:

maintainers         {kimuraw @kimuraw} openmaintainer


> +# Add the architecture flag as required
> +if {[info exists build_arch] && ${build_arch} != ""} {
> +    configure.args-append "--with-arch=${build_arch}"
> +}

It has been many years since build_arch was added to MacPorts base, so there's no longer any reason to check for its existence before using it. Just go ahead and use it.


> +variant doc description "Install rdoc indexes and C API documents" {
> +        configure.args-delete   --disable-install-doc
> +}

You should indent to 4 spaces, not 8 spaces (see the modeline at the top of the portfile).