science/lalinference: update to 1.8.2

[Adam Mercer]

On Sat, Jan 7, 2017 at 6:04 AM, Joshua Root <jmr at macports.org> wrote:

>> <https://github.com/macports/macports-ports/commit/8204bbd6dc77a96a35c0c6eb8a3045330e94596a>
>>
>>
>> This also reverted
>>
>> <https://github.com/macports/macports-ports/commit/056c2be9d7241386a685bd19f0529db5fb958527>,
>> which really is necessary. In general because you don't control the
>> value of $frameworks_dir, and it could contain characters which have
>> special meaning in a regex, and because string replacement on a Tcl list
>> is hard enough to get right. And specifically because in MacPorts 2.4 we
>> will once again be setting prefix to '${prefix}' while building the
>> PortIndex (the code that does that was accidentally non-functional in
>> 2.3).

Thanks for pointing that out, I'll get that change back in place. This
change was dropped due to the way we currently managed these ports, we
develop them out of a different repository and then when they're ready
we just copy them to the MacPorts git reposiry and commit. We really
need to find a more sane way as things like this are bound to happen
again.

It also sounds like a similar change should be made to the other lal* ports.

> Although I see I also made a typo; sorry about that. The dollar sign should
> be in front of the first brace on line 121, not in front of the bracket.

I assume you mean the following:

diff --git a/science/lalinference/Portfile b/science/lalinference/Portfile
index 018a9d96ed..f92ad99bbb 100644
--- a/science/lalinference/Portfile
+++ b/science/lalinference/Portfile
@@ -118,7 +118,7 @@ foreach v {27 34 35} {
     depends_lib-replace   port:lal port:py${v}-lal
     depends_lib-append    port:${name} port:py${v}-numpy

-    configure.args-strsed s|$[quotemeta
{default_pythonarg}]|PYTHON=[quotemeta
${pythonhome}/bin/python${pythonversion}]|
+    configure.args-strsed s|[quotemeta
${default_pythonarg}]|PYTHON=[quotemeta
${pythonhome}/bin/python${pythonversion}]|
     configure.args-replace --disable-python --enable-python
     configure.args-append --enable-swig-python

Cheers

Adam