[macports-ports] branch master updated: gnutls: add compiler blacklist for Snow Leopard build issue

[Ryan Schmidt]

> On Jan 12, 2017, at 18:21, Marius Schamschula <mps at macports.org> wrote:
> 
> Marius Schamschula (Schamschula) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/46f834998a6e47ff74fdbd65e47b9cb10cc716c6
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new 46f8349  gnutls: add compiler blacklist for Snow Leopard build issue
> 
> 46f8349 is described below
> 
> 
> commit 46f834998a6e47ff74fdbd65e47b9cb10cc716c6
> 
> Author: Marius Schamschula <mps at macports.org>
> AuthorDate: Thu Jan 12 18:20:43 2017 -0600
> 
> 
>     gnutls: add compiler blacklist for Snow Leopard build issue
> 
> ---
>  devel/gnutls/Portfile | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> 
> diff --git a/devel/gnutls/Portfile b/devel/gnutls/Portfile
> 
> index e2e6673..d7ae0df 100644
> 
> --- a/devel/gnutls/Portfile
> 
> +++ b/devel/gnutls/Portfile
> 
> @@ -1,6 +1,8 @@
> 
>  # -*- Mode: Tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:et:sw=4:ts=4:sts=4
>  
>  PortSystem      1.0
> 
> +
> 
> +PortGroup       compiler_blacklist_versions 1.0
> 
You can remove this since you're not actually using the features of this portgroup. Except that I see that /usr/bin/clang failed to build it too, so you may need this portgroup after all to blacklist older versions of clang.

>  PortGroup       muniversal 1.0
>  
>  name            gnutls
> 
> @@ -110,6 +112,10 @@ platform darwin 8 {
> 
>      depends_build-append   port:texinfo
>  }
>  
> 
> +platform darwin 10 {
> 
> +    compiler.blacklist-append gcc-4.2
> 
> +}

This seems unlikely to be the correct solution. It seems unlikely that gcc 4.2 on Snow Leopard would be unfamiliar with AVX instructions, but that gcc 4.2 on Leopard would be.

You tested on Leopard PowerPC and didn't have a problem, but AVX are Intel-specific instructions so it's likely that a PowerPC build wouldn't attempt to use them anyway.

The correct statement is probably to blacklist gcc-4.2 when building for Intel. Note that "platform i386" isn't necessarily sufficient for that, since one could conceivably be building an i386/ppc universal binary on a PowerPC Mac.

It seems likely that apple-gcc-4.2 (which is the default compiler on Tiger) would have the same problem, and a ticket about this issue showed that llvm-gcc-4.2 was having the problem too, so you should blacklist "*gcc-4.2*" to catch all those cases.