Travis: failed build reported as successful

[Zero King]

On Sat, Jul 01, 2017 at 09:21:42AM +0200, Mojca Miklavec wrote:
>I would say that
>    portindex || exit 1
>should work.

Does this make a difference? `portindex` returns 0 (success) even if
parse error occurred.

>When individual steps could fail and when I wanted to proceed
>executing the script to the end, I usually wrote a function that
>checked for failure status and only reported / generated a failure at
>the end. But I guess you can safely exit if portindex fails
>(potentially add some explicit sentence saying so if it's not clear
>from the error message).

If portindex couldn't parse the Portfile, I'd say we shouldn't waste
Travis's resource on the PR.

Another problem is that if our master branch contains broken Portfiles
(committed between PR parent commit and Travis build), should the build
fail and warn us or should we filter the irrelevant errors?

>Mojca

-- 
Best regards,
Zero King

Don't trust the From address.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3612 bytes
Desc: not available
URL: <http://lists.macports.org/pipermail/macports-dev/attachments/20170701/3bebad49/attachment-0001.bin>