[macports-ports] branch master updated: google-perftools: replaced by gperftools

[Ryan Schmidt]

> On May 14, 2017, at 06:04, Zero King <l2dy at macports.org> wrote:
> 
> --- a/www/nginx/Portfile
> 
> +++ b/www/nginx/Portfile
> 
> @@ -160,19 +160,19 @@ variant geoip description {Enable Ngx http GeoIP module (http://wiki.nginx.org/H
>      depends_lib-append      port:libgeoip
>  }
>  
> 
> -variant google_perftools description {Enable Google Performance Tools profiling for workers} {
> 
> +variant gperftools description {Enable Google Performance Tools profiling for workers} {
> 
>      configure.args-append   --with-google_perftools_module
> 
> -    depends_lib-append      port:google-perftools
> 
> +    depends_lib-append      port:gperftools
> 
>  
>      # If 'google_perftools' port doesn't find headers needed for the profiler lib, it just quietly skips it.
>      # Check if "-lprofiler" will fail -- if so, pre-empt configure-stage error with a more useful error msg.
>      pre-configure {
>          if {![file exists "${prefix}/lib/libprofiler.dylib"] && ![file exists "${prefix}/lib/libprofiler.a"]} {
>              ui_error "\
> 
> -                The 'google-perftools' port did not install a libprofiler library (libprofiler.dylib or\
> 
> +                The 'gperftools' port did not install a libprofiler library (libprofiler.dylib or\
> 
>                  libprofiler.a) on your version of OS X, but the +google_perftools variant will not work\
>                  without this library. Disable the +google_perftools variant to continue installing ${name}"
> 
> -            error "Required libprofiler library missing from google-perftools port."
> 
> +            error "Required libprofiler library missing from gperftools port."
> 
>          }
>      }
>  }
> 


Users of nginx who had the google_perftools variant installed will now suddenly not have it anymore, the next time they upgrade or reinstall the port. To prevent that, you should keep a stub google_perftools variant around for a year to help those users upgrade properly.

# Can be removed after May 2018
variant google_perftools requires gperftools description {Legacy compatibility variant}