[macports-ports] branch master updated: openntpd: add https variant, formatting

[Ryan Schmidt]

> On May 18, 2017, at 22:09, Zero King <l2dy at macports.org> wrote:
> 
> Zero King (l2dy) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/567f456fd11ec6bf1572cfa1c4c460e47f162c90
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new 567f456  openntpd: add https variant, formatting
> 
> 567f456 is described below
> 
> 
> commit 567f456fd11ec6bf1572cfa1c4c460e47f162c90
> 
> Author: Zero King <l2dy at macports.org>
> AuthorDate: Fri May 19 03:09:22 2017 +0000
> 
> 
>     openntpd: add https variant, formatting
> 
> ---
>  net/openntpd/Portfile | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> 
> diff --git a/net/openntpd/Portfile b/net/openntpd/Portfile
> 
> index 4a7b7bf..f8486ce 100644
> 
> --- a/net/openntpd/Portfile
> 
> +++ b/net/openntpd/Portfile
> 
> @@ -16,19 +16,20 @@ long_description    OpenNTPD is a free, easy to use implementation of the \
> 
>                      local clock to remote NTP servers and can act as NTP server \
>                      itself, redistributing the local clock.
>  
> 
> +conflicts           ntp
> 
> +
> 
>  homepage            http://www.openntpd.org/
>  master_sites        openbsd:OpenNTPD
>  
>  checksums           rmd160  a07b4c96d843c206550a20f839485c04771916b8 \
>                      sha256  b1ab80094788912adb12b33cb1f251cc58db39294c1b5c6376972f5f7ba577e8
>  
> 
> -conflicts           ntp
> 
> -
> 
>  startupitem.create     yes
>  startupitem.netchange  yes
>  startupitem.executable ${prefix}/sbin/ntpd -d -s -f ${prefix}/etc/ntpd.conf
>  
> 
> -configure.args      --mandir=${prefix}/share/man
> 
> +configure.args      --mandir=${prefix}/share/man \
> 
> +                    --disable-https-constraint
> 
>  
>  add_users           _ntp group=_ntp home=${prefix}/var/db/ntpd \
>                      shell=/usr/bin/false realname=OpenNTPD\ Server
> 
> @@ -48,6 +49,11 @@ post-activate {
> 
>      }
>  }
>  
> 
> +variant https description {Enable HTTPS Constraint Functionality} {
> 
> +    depends_lib-append    path:lib/libtls.dylib:libressl
> 
> +    configure.args-delete --disable-https-constraint
> 
> +}

Why does this https variant default to libressl (while allowing openssl), when other ports default to openssl (while allowing libressl)? libressl is *not* a drop-in replacement for openssl, in that ports have to be recompiled to use a different ssl library. By defaulting to libressl here, you guarantee that users who install this port with the https variant first will get libressl, and if they then install any other port that depends on *ssl, the binaries they receive will be broken and will need to be recompiled from source.