[macports-ports] 01/03: zenlib: change from CamelCase to lowercase

[Ryan Schmidt]

On Nov 7, 2017, at 07:39, Craig Treleaven wrote:

> Craig Treleaven (ctreleaven) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/8345df9894fc844cd5110c147e32a5357d96f127
> 
> commit 8345df9894fc844cd5110c147e32a5357d96f127
> 
> Author: Craig Treleaven <ctreleaven at macports.org>
> AuthorDate: Tue Nov 7 08:21:58 2017 -0500
> 
> 
>     zenlib:  change from CamelCase to lowercase
>     
>     See https://trac.macports.org/ticket/55241


> --- a/devel/zenlib/Portfile
> +++ b/devel/zenlib/Portfile
> @@ -4,7 +4,7 @@ PortSystem          1.0
>  PortGroup           github 1.0
>  PortGroup           cmake 1.0
>  
> -github.setup        MediaArea ZenLib 0.4.37 v 
> +github.setup        MediaArea zenlib 0.4.37 v

This is not correct, and does not work because the GitHub project name is "ZenLib", not "zenlib":


$ sudo port extract zenlib
--->  Fetching distfiles for zenlib
--->  Verifying checksums for zenlib
--->  Extracting zenlib
Error: 

github PortGroup: Error: tarball name is not as expected. This might mean that the repository name is different than set in the Portfile. Please review and try to correct.

Error: Failed to extract zenlib: Unexpected github tarball extract.
Error: See /opt/local/var/macports/logs/_Users_rschmidt_macports_macports-ports-svn-trunk_devel_zenlib/zenlib/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port zenlib failed


The github.setup line should use the author or organization name and project name exactly as it appears on GitHub. If the port name is to differ from the GitHub project name, you can add a "name" line.

The same goes for the mediainfo and mediainfolib ports. Their extract phases don't fail after this change, because they override the github portgroup's master_sites with an archive URL, and the GitHub portgroup only runs that check if you haven't changed master_sites. Instead, the configure phase will fail on case-sensitive filesystems, like those the buildbot workers use, because the case of the extracted directory does not match the case of the project name you supplied.

The next time you update those ports' versions, please remove the master_sites override. If you think archive URLs are better than tarball URLs, please implement support for them in the portgroup, not in individual ports; see https://trac.macports.org/ticket/40518.